Add response flags into cel expression context (#8827) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Add response flags into expression context Risk Level: low Testing: unit test Docs Changes: Release Notes: Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
|
Cherry-pick of envoyproxy@c60da46 |
|
cc @mandarjog |
|
@howardjohn Can we please merge this? Thanks! |
howardjohn
pushed a commit
that referenced
this pull request
Mar 3, 2020
Description: Remove empty slices off the end of buffers after calls to OwnedImpl::commit. The slices reserved when OwnedImpl::reserve is called will sit unused in cases where the 0 bytes are commited, for example, when socket read returns 0 bytes EAGAIN. Trapped slices act like a memory leak until there is a successful read or the socket is closed. Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Yangmin Zhu <ymzhu@google.com>
istio-testing
pushed a commit
that referenced
this pull request
Mar 3, 2020
Description: Remove empty slices off the end of buffers after calls to OwnedImpl::commit. The slices reserved when OwnedImpl::reserve is called will sit unused in cases where the 0 bytes are commited, for example, when socket read returns 0 bytes EAGAIN. Trapped slices act like a memory leak until there is a successful read or the socket is closed. Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a Signed-off-by: Asra Ali <asraa@google.com> Co-authored-by: asraa <asraa@google.com>
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Mar 10, 2020
Description: Remove empty slices off the end of buffers after calls to OwnedImpl::commit. The slices reserved when OwnedImpl::reserve is called will sit unused in cases where the 0 bytes are commited, for example, when socket read returns 0 bytes EAGAIN. Trapped slices act like a memory leak until there is a successful read or the socket is closed. Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a Signed-off-by: Asra Ali <asraa@google.com>
fpesce
pushed a commit
that referenced
this pull request
Jun 30, 2020
Description: Remove empty slices off the end of buffers after calls to OwnedImpl::commit. The slices reserved when OwnedImpl::reserve is called will sit unused in cases where the 0 bytes are commited, for example, when socket read returns 0 bytes EAGAIN. Trapped slices act like a memory leak until there is a successful read or the socket is closed. Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a Signed-off-by: Asra Ali <asraa@google.com>
brian-avery
pushed a commit
that referenced
this pull request
Jun 30, 2020
Description: Remove empty slices off the end of buffers after calls to OwnedImpl::commit. The slices reserved when OwnedImpl::reserve is called will sit unused in cases where the 0 bytes are commited, for example, when socket read returns 0 bytes EAGAIN. Trapped slices act like a memory leak until there is a successful read or the socket is closed. Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Yangmin Zhu <ymzhu@google.com>
Miss-you
pushed a commit
to Miss-you/envoy
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add response flags into expression context
Risk Level: low
Testing: unit test
Docs Changes:
Release Notes:
Signed-off-by: Pengyuan Bian bianpengyuan@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]