Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick filter state PRs needed for TCP telemetry #142

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

kyessenov
Copy link

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov changed the title Cherry-pick filter state PRs Cherry-pick filter state PRs needed for TCP telemetry Feb 6, 2020
@kyessenov
Copy link
Author

Some commit is missing:

source/extensions/common/wasm/context.cc:1016:29: error: no member named 'setData' in 'std::shared_ptr<Envoy::StreamInfo::FilterState>'; did you mean to use '->' instead of '.'?
  stream_info->filterState().setData(key, std::make_unique<WasmState>(serialized_value),

Signed-off-by: Kuat Yessenov <kuat@google.com>
@gargnupur
Copy link

Thanks @kyessenov

@kyessenov
Copy link
Author

@jplevyak Can you confirm that the last commit is all I need to do to Wasm bits to make it work?

@kyessenov
Copy link
Author

Target //source/exe:envoy-static up-to-date:
  bazel-bin/source/exe/envoy-static
INFO: Elapsed time: 47.512s, Critical Path: 46.92s
INFO: 27 processes: 27 linux-sandbox.
INFO: Build completed successfully, 30 total actions

Add access to upstreamfilterstate in WasmStateWrapper
@kyessenov kyessenov merged commit 892453e into istio:release-1.5 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants