Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contain icon, offset feature #145

Merged
merged 2 commits into from
Aug 20, 2016
Merged

contain icon, offset feature #145

merged 2 commits into from
Aug 20, 2016

Conversation

dangreen
Copy link
Contributor

@dangreen dangreen commented Aug 19, 2016

Source:
source
Before:
before
After:
after
After with offset:
after with offset

Now you can set offset (in percents) in config, example:

let config = {
    background: "#0030d9",
    logging: true, 
    online: false,
    icons: {
        android:      false, // Create Android homescreen icon. `boolean`
        appleIcon:    { offset: 30 }, // Create Apple touch icons. `boolean`
        appleStartup: false, // Create Apple startup images. `boolean`
        firefox:      false, // Create Firefox OS icons. `boolean`
        windows:      false, // Create Windows 8 tile icons. `boolean`
        coast:        { offset: 30 },  // Create Opera Coast icon. `boolean`
        favicons:     true,  // Create regular favicons. `boolean`
        yandex:       true   // Create Yandex browser icon. `boolean`
    }
};

@@ -116,8 +118,12 @@ const _ = require('underscore'),
const response = { images: [], files: [], html: [] };

async.forEachOf(options.icons, (enabled, platform, cb) => {
const platformOptions = typeof enabled == "object"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tighten this up into one line please?

@haydenbleasel
Copy link
Contributor

Awesome PR, can you check the comment I just dropped?

Also, we're going to need README updates.

@haydenbleasel
Copy link
Contributor

Great stuff 👍 Just waiting for Travis then I'll merge.

@haydenbleasel haydenbleasel merged commit 99a7993 into itgalaxy:master Aug 20, 2016
uwolfer added a commit to uwolfer/favicons that referenced this pull request Aug 26, 2018
- move favicons to top in order to fix Chrome issue which issues unnecessary network requests on route change; see also:
  - https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change
  - ctrlplusb/react-universally#145
- preserve order of items inside one platform definition which allows to define a useful order

Fixes issue itgalaxy#145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants