Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from TSD to typings #446

Closed
wants to merge 5 commits into from
Closed

Conversation

demurgos
Copy link
Contributor

Hi,
This PR updates the definition files management from TSD to typings and fixes #436.

The build instructions were updated to include typings install after npm install.

I could successfully build gulp-typescript and was I able to remove the warning I got as a consumer (tsd.d.ts not found), but I'd still be careful with this PR to ensure that it does not introduce any breaking changes.

@demurgos
Copy link
Contributor Author

demurgos commented Oct 21, 2016

Hi,
I know that this is a change in the build process so it requires some time to review it. Do you need more details ? I would gladly help you clarify and test any potential issues.

I have some dependent packages that throw errors because of #436 and I hoped to solve it quickly.

@ivogabe
Copy link
Owner

ivogabe commented Oct 22, 2016

Sorry for the late reply, I didn't have time to look at this earlier. I also looked at your types branch, and got that working after two changes. You accidentally included both types and typings, so all libraries were declared twice. The tests would also pick up the @types files, which broke several tests. I explicitly excluded the @types files and now all tests pass again. Can you take a look at #448 and see whether that works for you?

@demurgos
Copy link
Contributor Author

demurgos commented Oct 22, 2016

Ok, I'll check that, looks like you are right: I forgot to completely remove typings.

@demurgos
Copy link
Contributor Author

I am closing this PR in favor of #448.

@demurgos demurgos closed this Oct 24, 2016
@demurgos demurgos deleted the typings branch November 5, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_modules/gulp-typescript/typings/tsd.d.ts not found.
2 participants