Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW-FEATURE] Add border when rendering arrays of complex types #56

Closed
PTKu opened this issue Feb 8, 2023 · 2 comments · Fixed by #57
Closed

[NEW-FEATURE] Add border when rendering arrays of complex types #56

PTKu opened this issue Feb 8, 2023 · 2 comments · Fixed by #57
Assignees
Labels

Comments

@PTKu
Copy link
Member

PTKu commented Feb 8, 2023

Having following:

NAMESPACE MonsterData
    CLASS MonsterBase
        VAR PUBLIC
            ArrayOfBytes : ARRAY[0..3] OF BYTE;
            ArrayOfDrives : ARRAY[0..3] OF DriveBase;
        END_VAR        
    END_CLASS
    CLASS Monster EXTENDS MonsterBase
        VAR PUBLIC
            DriveA : DriveBase;
        END_VAR        
    END_CLASS

    CLASS DriveBase
        VAR PUBLIC
            Position : LREAL;
            Velo : LREAL;
            Acc : LREAL;
            Dcc : LREAL;            
        END_VAR        
    END_CLASS
END_NAMESPACE

The arrays are now rendered as:

For primitive types we are good:
image

For complex types we should add a border (or something like that) with label to delimit the part belonging to an index of an array
image

@PTKu PTKu added the blazor label Feb 8, 2023
@PTKu PTKu changed the title [NEW-FEATURE] [NEW-FEATURE] Add border when rendering arrays of complex types Feb 8, 2023
@Specter-13
Copy link
Collaborator

/cib

@PTKu
Copy link
Member Author

PTKu commented Feb 8, 2023

PTKu pushed a commit that referenced this issue Feb 8, 2023
@PTKu PTKu closed this as completed in #57 Feb 8, 2023
PTKu added a commit that referenced this issue Feb 8, 2023
* Create draft PR for #56

* added wrapper around unknown complex type in arrays

---------

Co-authored-by: Specter-13 <Specter-13@users.noreply.github.com>
Co-authored-by: Specter-13 <56168909+Specter-13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants