[Synthetics] fix browser type as default in monitor management (elast…

…ic#132572) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
j-bennet · Jun 2, 2022 · 2c0f3fc · 2c0f3fc
1 parent 564e832
commit 2c0f3fc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/x-pack/plugins/synthetics/e2e/journeys/monitor_details.journey.ts b/x-pack/plugins/synthetics/e2e/journeys/monitor_details.journey.ts
@@ -40,12 +40,12 @@ journey('MonitorDetails', async ({ page, params }: { page: Page; params: any })
   step('create basic monitor', async () => {
     await uptime.enableMonitorManagement();
     await uptime.clickAddMonitor();
-    await uptime.createBasicMonitorDetails({
+    await uptime.createBasicHTTPMonitorDetails({
       name,
       locations: ['US Central'],
       apmServiceName: 'synthetics',
+      url: 'https://www.google.com',
     });
-    await uptime.fillByTestSubj('syntheticsUrlField', 'https://www.google.com');
     await uptime.confirmAndSave();
   });
 

diff --git a/x-pack/plugins/synthetics/e2e/journeys/monitor_name.journey.ts b/x-pack/plugins/synthetics/e2e/journeys/monitor_name.journey.ts
@@ -21,12 +21,12 @@ journey(`MonitorName`, async ({ page, params }: { page: Page; params: any }) =>
   const uptime = monitorManagementPageProvider({ page, kibanaUrl: params.kibanaUrl });
 
   const createBasicMonitor = async () => {
-    await uptime.createBasicMonitorDetails({
+    await uptime.createBasicHTTPMonitorDetails({
       name,
       locations: ['US Central'],
       apmServiceName: 'synthetics',
+      url: 'https://www.google.com',
     });
-    await uptime.fillByTestSubj('syntheticsUrlField', 'https://www.google.com');
   };
 
   before(async () => {
@@ -52,12 +52,12 @@ journey(`MonitorName`, async ({ page, params }: { page: Page; params: any }) =>
 
   step(`shows error if name already exists`, async () => {
     await uptime.navigateToAddMonitor();
-    await uptime.createBasicMonitorDetails({
+    await uptime.createBasicHTTPMonitorDetails({
       name,
       locations: ['US Central'],
       apmServiceName: 'synthetics',
+      url: 'https://www.google.com',
     });
-    await uptime.fillByTestSubj('syntheticsUrlField', 'https://www.google.com');
 
     await uptime.assertText({ text: 'Monitor name already exists.' });
 

diff --git a/x-pack/plugins/synthetics/e2e/page_objects/monitor_management.tsx b/x-pack/plugins/synthetics/e2e/page_objects/monitor_management.tsx
@@ -189,6 +189,7 @@ export function monitorManagementPageProvider({
       apmServiceName: string;
       locations: string[];
     }) {
+      await this.selectMonitorType('http');
       await this.createBasicMonitorDetails({ name, apmServiceName, locations });
       await this.fillByTestSubj('syntheticsUrlField', url);
     },

diff --git a/...nthetics/public/legacy_uptime/components/fleet_package/contexts/policy_config_context.tsx b/...nthetics/public/legacy_uptime/components/fleet_package/contexts/policy_config_context.tsx
@@ -121,10 +121,10 @@ export function PolicyConfigContextProvider<ExtraFields = unknown>({
   const isAddMonitorRoute = useRouteMatch(MONITOR_ADD_ROUTE);
 
   useEffect(() => {
-    if (isAddMonitorRoute) {
+    if (isAddMonitorRoute?.isExact) {
       setMonitorType(DataStream.BROWSER);
     }
-  }, [isAddMonitorRoute]);
+  }, [isAddMonitorRoute?.isExact]);
 
   const value = useMemo(() => {
     return {