Add NodeReplacer for BinaryExpr where it is a VectorSelector + Literal #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
commented
Sep 7, 2024
jacksontj
force-pushed
the
issue_673
branch
from
e2e7cee
to
6512517
Compare
VectorSelector/AggregateExpr If the query is something like `foo>1` prior to this patch we unwrap and send down to each downstream `foo` and then do the comparison (binaryExpr) in promxy. This is non-ideal as we are sending some data back that could have been dropped at the remote end. Although this is a great performance optimization we will need to be careful when adding cases to this. For BinaryExprs to be sent to each servergroup in a `valid` way the query must be "local" to a given servergroup. For example; `sum(foo)>1` would *not* be safe to send downstream as `sum(foo)` requires adding across a variety of servergroups to determine the correct value. Fixes #673
jacksontj
force-pushed
the
issue_673
branch
from
6512517
to
b0f6fb8
Compare
This is a first-pass as we are starting to get more complex in what we support here (especially with subquery).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the query is something like
foo>1prior to this patch we unwrap and send down to each downstreamfooand then do the comparison (binaryExpr) in promxy. This is non-ideal as we are sending some data back that could have been dropped at the remote end.Although this is a great performance optimization we will need to be careful when adding cases to this. For BinaryExprs to be sent to each servergroup in a
validway the query must be "local" to a given servergroup. For example;sum(foo)>1would not be safe to send downstream assum(foo)requires adding across a variety of servergroups to determine the correct value.Fixes #673