Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ILM documentation #471

Closed
albertteoh opened this issue Jan 22, 2021 · 3 comments · Fixed by #474
Closed

Add ILM documentation #471

albertteoh opened this issue Jan 22, 2021 · 3 comments · Fixed by #474

Comments

@albertteoh
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

Add documentation relating to this PR: jaegertracing/jaeger#2454

The changes should update the Elasticsearch deployment section, especially to Elasticsearch Rollover: https://www.jaegertracing.io/docs/1.21/deployment/#elasticsearch.

@bhiravabhatla
Copy link
Contributor

@albertteoh - I see an unclosed tag (<1>) at the beginning of few lines in elasticsearch section. Is this expected?

image

@albertteoh
Copy link
Contributor Author

albertteoh commented Feb 3, 2021

Yup, this is expected. It's hard to see but if you scroll across the docker run... command, you'll see a # <1>; which acts as an anchor for the comment. A clearer example of how this is used is here: https://www.jaegertracing.io/docs/1.21/operator/#understanding-custom-resource-definitions

bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 3, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
@bhiravabhatla
Copy link
Contributor

Oh okay, I removed them in my PR, let me add them back

bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 3, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 3, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 4, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 4, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
bhiravabhatla added a commit to bhiravabhatla/documentation that referenced this issue Feb 4, 2021
Signed-off-by: santosh <bsantosh@thoughtworks.com>
yurishkuro pushed a commit that referenced this issue Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants