Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] - allinone use tpl function for args #428

Merged
merged 3 commits into from
Jan 4, 2023
Merged

[jaeger] - allinone use tpl function for args #428

merged 3 commits into from
Jan 4, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Jan 4, 2023

Signed-off-by: Pierre Tessier pierre@pierretessier.com

What this PR does

Uses the Helm tpl function to allow for command line args to be templated. This is required when Jaeger is used as a chart dependency and some options can only be determined at helm templating time (ie: release name).

Which issue this PR fixes

This allows for the OpenTelemetry demo to leverage Jaeger for tracing with Prometheus-backed metrics store configured in the Jaeger AllInOne deploy as merged recently in the otel demo PR 655

The OpenTelemetry demo helm chart will have a section to configure the prometheus sever url that looks like this:

  allInOne:
    enabled: true
    args:
      - "--prometheus.server-url"
      - 'http://{{ include "otel-demo.name" . }}-prometheus-server:9090'
    extraEnv:
      - name: METRICS_STORAGE_TYPE
        value: prometheus

Passing in the {{ include "otel-demo.name" .}} portion for the command line argument is what this PR enables.

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@naseemkullah naseemkullah merged commit 116a4af into jaegertracing:main Jan 4, 2023
@puckpuck puckpuck deleted the puckpuck.use_tpl_for_args branch January 5, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants