Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Enabling logSpans flag causes exception #123

Closed
yurishkuro opened this issue Jun 2, 2017 · 2 comments
Closed

Enabling logSpans flag causes exception #123

yurishkuro opened this issue Jun 2, 2017 · 2 comments
Assignees

Comments

@yurishkuro
Copy link
Member

The logging reporter writes the span with JSON.stringify, which fails because of some recursive links in the span.

Instead, it should log the span in the same format as other clients, as trace context + operation name.

@rajeshsegu
Copy link

rajeshsegu commented Sep 27, 2017

Is there a reason why we are not using just util.inspect since this is a node only framework

util.inspect(span, {depth: 3});

Happy to send a pull request, if you like the solution.

@yurishkuro
Copy link
Member Author

I don't see the need for logging any details of the span itself. For example, in Go client the log looks like this

2017/09/22 20:26:49 Reporting span 5642914c078ef2f0:5642914c078ef2f0:0:1

@ghost ghost assigned tiffon and black-adder Aug 7, 2018
Iuriy-Budnikov pushed a commit to agile-pm/jaeger-client-node that referenced this issue Sep 25, 2021
Change return type "unknow" to HttpTextFormat for getHttpTextFormat
Change return type "unknow" to BinaryFormat for getBinaryFormat
Close jaegertracing#124 jaegertracing#123

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants