This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Fix buffer overflow in UDPSender #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer overflow fix
|
can we reproduce the issue in the unit test? |
|
Hi guys, any updates on this? It's happening also to me |
|
Unfortunately, this is not in a state where it can be merged: no DCO, build is broken, and no unit tests. |
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
* refactor: move Resource to @opentelemetry/sdk-base Moves the Resource interface to the SDK level by creating a new packaged called sdk-base. Also helps resolve the issue of shared objects between the metrics and trace SDK. * ftb * bump version to 0.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer overflow fix
Which problem is this PR solving?
Resolves #382
Short description of the changes
Added a new function to flush with a pending span : add a new totalSpanBytes test before span push on flush end, if we have enough space we push the pending span to spans array, if not, we recursively call the new flushWithPendingSpan function.
That solved the problem for me, but maybe isn't the best way to do. No unit tests, it's just for code comparison.