This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add config for maxUdpPacketSize #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous hostname foo.bar.xyz successfully resolves now, which causes these tests to fail. RFC 2606 reserves the .invalid TLD for hostnames that are invalid, so we should use that instead. Signed-off-by: Eric Culp <eric@getclockwise.com>
The maximum UDP packet size isn't necessarily 65k, and the code as written can drop lots of spans if it's any smaller. E.g. darwin has a 9k max size by default. Signed-off-by: Eric Culp <eric@getclockwise.com>
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
- Coverage 98.72% 98.67% -0.05%
==========================================
Files 50 50
Lines 2035 2037 +2
Branches 383 384 +1
==========================================
+ Hits 2009 2010 +1
- Misses 26 27 +1
Continue to review full report at Codecov.
|
|
Any tests that can be added? Any changes to documentation required? IIRC there's a section in the README that specifically talks about packet sizes, may be worth mentioning this new config option there. |
|
No response from the author, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
The tests were also failing, so there is also a small commit to fix some invalid hostnames to be invalid.