Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Nodetool drain for C* #21

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Nodetool drain for C* #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bd1648
Nodetool drain on preStop
pavolloffay Jul 25, 2017
59cbb7a
Use only nodetool drain in preStop
pavolloffay Jul 26, 2017
f709d43
fix minikube
pavolloffay Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion production/jaeger-production-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ items:
app: cassandra
jaeger-infra: cassandra-replica
spec:
terminationGracePeriodSeconds: 1800
containers:
- name: cassandra
image: cassandra:3.11
Expand All @@ -74,7 +75,7 @@ items:
lifecycle:
preStop:
exec:
command: ["/bin/sh", "-c", "PID=$(pidof java) && kill $PID && while ps -p $PID > /dev/null; do sleep 1; done"]
command: ["/bin/sh", "-c", "nodetool drain"]
env:
- name: MAX_HEAP_SIZE
value: 512M
Expand Down
2 changes: 1 addition & 1 deletion travis/install-start-minikube.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ mkdir $HOME/.kube || true
touch $HOME/.kube/config

export KUBECONFIG=$HOME/.kube/config
sudo -E ./minikube start --vm-driver=none --use-vendored-driver
Copy link
Member Author

@pavolloffay pavolloffay Jul 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They removed --use-vendored-driver in the last version which was released yesterday.

We can use a specific minikube version to avoid failures like this. (but I prefer to use latest for now).

sudo -E ./minikube start --vm-driver=none

# this for loop waits until kubectl can access the api server that minikube has created
for i in {1..150} # timeout for 5 minutes
Expand Down