Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12 and 24 hour search lookbacks not converted to start timestamp correctly #167

Closed
tiffon opened this issue Jan 9, 2018 · 0 comments · Fixed by #168
Closed

12 and 24 hour search lookbacks not converted to start timestamp correctly #167

tiffon opened this issue Jan 9, 2018 · 0 comments · Fixed by #168
Labels
bug help wanted

Comments

@tiffon
Copy link
Member

tiffon commented Jan 9, 2018

Description

A JS bug causes start timestamp for the 12 hour and 24 hour lookback to be the same as the end timestamp.

Steps to reproduce the issue:

  1. Set the search lookback to either 12 hour or 24 hour
  2. Execute a search

Describe the results you received:

The start and end timestamps GET query parameters are the same.

Describe the results you expected:

The start timestamp should be the adjusted based on the lookback.
@tiffon tiffon mentioned this issue Jan 9, 2018
Closed
@golonzovsky golonzovsky mentioned this issue Jan 13, 2018
Merged
tiffon pushed a commit that referenced this issue Jan 15, 2018
@golonzovsky @tiffon
fixes #167: 2 digit lookback (12h, 24h) parsing (#168)
da464e5 
* fix 2 digit lookback (12h, 24h) parsing

Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>

* add double digit lookback options parsing test

Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@golonzovsky @tiffon
fixes jaegertracing#167: 2 digit lookback (12h, 24h) parsing (jaegert…
a08bb44 
…racing#168)

* fix 2 digit lookback (12h, 24h) parsing

Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>

* add double digit lookback options parsing test

Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #167: 2 digit lookback (12h, 24h) parsing
1 participant
@tiffon