Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert upgrade to viz.js, v2.1.2 -> v1.8.1 #1082

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

yurishkuro
Copy link
Member

Resolves #1077.

The upgrade was introduced in #1001. Sadly, we have no unit tests in /plexus/ module, so the break was not caught.

In #1001 the dependency viz.js was upgraded to the next major version (2.1.2), however it had breaking changes which were not accounted for.

Alternative paths tracked in #1081.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge (squash) November 25, 2022 00:28
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 95.30% // Head: 95.34% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (104860f) compared to base (07b62b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   95.30%   95.34%   +0.03%     
==========================================
  Files         243      243              
  Lines        7561     7561              
  Branches     1895     1895              
==========================================
+ Hits         7206     7209       +3     
+ Misses        348      345       -3     
  Partials        7        7              
Impacted Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 94.44% <0.00%> (-5.56%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 95.51% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit b523881 into jaegertracing:main Nov 25, 2022
@yurishkuro yurishkuro deleted the fix-1077 branch November 25, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Deep Dependency Graph" is not drawn.
2 participants