Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alt view dropdown to a button #1174

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

Sergio-Mira
Copy link
Contributor

@Sergio-Mira Sergio-Mira commented Feb 4, 2023

Alt View dropdown is currently a div which does not display a pointer cursor when hovering and you sometimes end selecting text in it.

Which problem is this PR solving?

  • Alt View button gets its text selected sometimes when clicking
  • Alt View dropdown shows text cursor instead of pointer cursor

Short description of the changes

Screenshot 2023-02-04 at 15 48 30

@yurishkuro
Copy link
Member

Do you mind adding a link to the relevant docs in the PR description?

@Sergio-Mira
Copy link
Contributor Author

From the looks of https://ant.design/components/dropdown examples it uses a <a> or a <Button>, which makes the right cursor appear.

Signed-off-by: Sergio-Mira <sergio.mira@zendesk.com>
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 95.30% // Head: 95.46% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (7a5ba41) compared to base (d0915ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   95.30%   95.46%   +0.15%     
==========================================
  Files         243      243              
  Lines        7561     7561              
  Branches     1895     1895              
==========================================
+ Hits         7206     7218      +12     
+ Misses        348      336      -12     
  Partials        7        7              
Impacted Files Coverage Δ
...nents/TracePage/TracePageHeader/AltViewOptions.tsx 100.00% <ø> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 97.93% <0.00%> (+4.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit f3da647 into jaegertracing:main Feb 5, 2023
@yurishkuro
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants