Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Remove @types/memoize-one dep #1625

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

anshgoyalevil
Copy link
Member

Which problem is this PR solving?

  • This PR removes the @types/memoize-one dep since this is a stub types definition. memoize-one provides its own type definitions

fixes #1624

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (0f3bfdd) 95.99% compared to head (67e23c3) 96.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
+ Coverage   95.99%   96.01%   +0.02%     
==========================================
  Files         242      242              
  Lines        7559     7559              
  Branches     1984     1984              
==========================================
+ Hits         7256     7258       +2     
+ Misses        303      301       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshgoyalevil
Copy link
Member Author

//cc @yurishkuro

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro merged commit 5489990 into jaegertracing:main Aug 1, 2023
8 checks passed
@anshgoyalevil anshgoyalevil deleted the memoize branch August 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deps]: Remove @types/memoize-one
2 participants