Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert utils/TreeNode.js and selectors/trace.js to Typescript #1777

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 12, 2023

Which problem is this PR solving?

  • missing typing

Description of the changes

  • convert two files to TS and fix compile/lint errors in the callers

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Convert src/utils/TreeNode.js to Typescript Convert utils/TreeNode.js and selectors/trace.js to Typescript Sep 12, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 95.12% of modified lines.

Files Changed Coverage
packages/jaeger-ui/src/selectors/trace.tsx 81.81%
...kages/jaeger-ui/src/model/transform-trace-data.tsx 100.00%
packages/jaeger-ui/src/utils/TreeNode.tsx 100.00%

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro marked this pull request as ready for review September 12, 2023 04:47
@yurishkuro yurishkuro merged commit 17eb291 into jaegertracing:main Sep 12, 2023
7 of 9 checks passed
@yurishkuro yurishkuro deleted the cleanup-cp branch September 12, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant