Add GA event tracking for actions in trace view #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 89.15% 89.08% -0.07%
==========================================
Files 98 104 +6
Lines 2222 2291 +69
Branches 460 466 +6
==========================================
+ Hits 1981 2041 +60
- Misses 203 211 +8
- Partials 38 39 +1
Continue to review full report at Codecov.
|
|
@simonrobb Can you look this PR over when you get the chance? |
Signed-off-by: Joe Farro <joef@uber.com>
simonrobb
approved these changes
Mar 2, 2018
|
|
||
| const context = 'jaeger/ux/trace/kbd-modal'; | ||
|
|
||
| export default function trackKbdHelpModal() { |
There was a problem hiding this comment.
Given you're tracking an event maybe be more verbose with the event being tracked. Suggestion: trackKbdHelpModalOpen
| const altViewCtx = 'jaeger/ux/trace/alt-view'; | ||
| export const slimHeaderCtx = 'jaeger/ux/trace/slim-header'; | ||
|
|
||
| export function trackAltView() { |
| }); | ||
| } | ||
|
|
||
| export function trackSlimHeader(isOpen: boolean) { |
There was a problem hiding this comment.
Suggestion: trackSlimHeaderStateChange
src/index.js
Outdated
| import JaegerUIApp from './components/App'; | ||
| import { context as trackingContext } from './utils/tracking'; | ||
|
|
||
| // these need to go after the App import |
There was a problem hiding this comment.
Doh! Merge conflicts... Thanks!
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
simonrobb
approved these changes
Mar 23, 2018
yurishkuro
approved these changes
Mar 23, 2018
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Track errors in GA w raven-js; TODO: tests, readme Signed-off-by: Joe Farro <joef@uber.com> * Include CSS selector with last error breadcrumb Signed-off-by: Joe Farro <joef@uber.com> * README for GA error tracking Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup Signed-off-by: Joe Farro <joef@uber.com> * README info on GA Application Tracking Signed-off-by: Joe Farro <joef@uber.com> * Misc fix to tracking README Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup to raven message conversion to GA Signed-off-by: Joe Farro <joef@uber.com> * Tests for tracking Signed-off-by: Joe Farro <joef@uber.com> * Apply prettier to markdown files Signed-off-by: Joe Farro <joef@uber.com> * Error tracking fn name fallback, CSS import order Signed-off-by: Joe Farro <joef@uber.com> * GA event tracking in trace view, tests are TODO Signed-off-by: Joe Farro <joef@uber.com> * Fix broken tests Signed-off-by: Joe Farro <joef@uber.com> * Tests for TracePage tracking Signed-off-by: Joe Farro <joef@uber.com> * Additional tests for trace GA event tracking Signed-off-by: Joe Farro <joef@uber.com> * Better names for tracking functions Signed-off-by: Joe Farro <joef@uber.com> * Make GA event tracking more concise (PR feedback) Signed-off-by: Joe Farro <joef@uber.com> * Revert the "more concise" changes Signed-off-by: Joe Farro <joef@uber.com> * Update changelog Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #157.
Adds GA event tracking for trace view.
This adds events for:
Search and dependency graphs are outstanding and will likely be a different PR.