Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a sanely sized canvas for the span mini-map #257

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Sep 27, 2018

Fix #256.

Optimize the span mini-map in the trace detail view to not create a huge canvas when dealing with large traces.

Time to draw the mini-map for a trace with around 10,000 spans:

Duration Seconds Ratio
Before 1.437 seconds
After 0.093 seconds 0.06

The main code change is to use sane limits for width and height when sizing the canvas.

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Sep 27, 2018
@ghost ghost added the review label Sep 27, 2018
@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #257 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage    77.6%   77.59%   -0.01%     
==========================================
  Files         135      135              
  Lines        2934     2933       -1     
  Branches      608      608              
==========================================
- Hits         2277     2276       -1     
  Misses        520      520              
  Partials      137      137
Impacted Files Coverage Δ
.../components/TracePage/SpanGraph/CanvasSpanGraph.js 100% <100%> (ø) ⬆️
...mponents/TracePage/SpanGraph/render-into-canvas.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6b248...2aa967e. Read the comment docs.

@yurishkuro yurishkuro merged commit 5fbf9a9 into master Sep 27, 2018
@ghost ghost removed the review label Sep 27, 2018
@yurishkuro yurishkuro deleted the tiffon/leaner-span-graph branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants