Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goToTrace #324

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fix goToTrace #324

merged 1 commit into from
Feb 7, 2019

Conversation

tacigar
Copy link
Contributor

@tacigar tacigar commented Feb 6, 2019

Which problem is this PR solving?

Short description of the changes

  • Fix goToTrace

before

jaeger-back-button

after

after

@tacigar
Fix goToTrace (jaegertracing#323)
f10a6b7 
Signed-off-by: Takuma Igarashi <ig.lhound@gmail.com>
@codecov
Copy link

codecov bot commented Feb 6, 2019 •
edited
Loading

Codecov Report

Merging #324 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   83.03%   83.03%   +<.01%     
==========================================
  Files         142      142              
  Lines        3147     3148       +1     
  Branches      649      649              
==========================================
+ Hits         2613     2614       +1     
  Misses        427      427              
  Partials      107      107
Impacted Files Coverage Δ
.../jaeger-ui/src/components/SearchTracePage/index.js 89.47% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f66f737...f10a6b7. Read the comment docs.

tiffon
tiffon approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@tiffon tiffon merged commit 5d0e712 into jaegertracing:master Feb 7, 2019
@tiffon tiffon mentioned this pull request Feb 7, 2019
Closed
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tacigar @tiffon
Fix goToTrace (jaegertracing#323) (jaegertracing#324)
a0ba64f 
Signed-off-by: Takuma Igarashi <ig.lhound@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffon tiffon tiffon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tacigar @tiffon