Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memoize-one instead of bespoke solutions #353

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Mar 20, 2019

Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Changed in-house made memoization functions to use memoize-one
  • I still need to review about React.memo on some PureComponents.

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #353 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   90.73%   90.87%   +0.13%     
==========================================
  Files         152      151       -1     
  Lines        3292     3275      -17     
  Branches      666      662       -4     
==========================================
- Hits         2987     2976      -11     
+ Misses        250      245       -5     
+ Partials       55       54       -1
Impacted Files Coverage Δ
...ts/TraceDiff/TraceDiffGraph/traceDiffGraphUtils.js 58.33% <100%> (+8.33%) ⬆️
.../jaeger-ui/src/components/SearchTracePage/index.js 88.13% <100%> (ø) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 90.74% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8359f8a...29e2d91. Read the comment docs.

@rubenvp8510 rubenvp8510 changed the title [WIP] Use memoize-one instead of bespoke solutions Use memoize-one instead of bespoke solutions Mar 25, 2019
@ghost ghost assigned everett980 Mar 25, 2019
@ghost ghost added the review label Mar 25, 2019
Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, great start! Looking forward to seeing the remaining memoization in a future PR!

@everett980 everett980 merged commit 3da2356 into jaegertracing:master Mar 25, 2019
@ghost ghost removed the review label Mar 25, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Use memoize-one instead of bespoke solutions
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants