-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema for configuring layers in plexus graphs #414
Schema for configuring layers in plexus graphs #414
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 174 174
Lines 3915 3915
Branches 897 897
=======================================
Hits 3581 3581
Misses 296 296
Partials 38 38 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Some questions but they may not lead to code changes just my own understanding of TypeScript.
// limitations under the License. | ||
|
||
export type TOneOf<A, B, C = {}, D = {}, E = {}> = | ||
| { [P in Exclude<keyof (B & C & D & E), keyof A>]?: null } & A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but: would undefined
be better than null
?
Schema for configuring layers in plexus graphs Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Which problem is this PR solving?
This is the first PR of a series of PRs that will enhance plexus by adding the ability to specify elements of a directed graph as a series of layers.
This PR adds the types necessary to configure layers, which is a large part of the public API of the new functionality.
Short description of the changes
This covers the types for the
layers
prop on the not-yet-createdLayeredDirectedGraph
component.See
TLayer
for the implementation.An example use of the component and
layers
prop: