Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch check from master branch #415

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Jul 16, 2019

Which problem is this PR solving?

Screen Shot 2019-07-16 at 5 24 22 PM

Currently if a PR that's merged to master has less than 90% coverage the Jaeger UI repo shows up as failing some checks even if the coverage for the project is above 90%.

This PR endeavor to remove the patch check from the master branch.

Short description of the changes

Add a .codecov.yml config file and configure to only apply the patch check to pull requests.

Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from everett980 July 16, 2019 21:51
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files         174      174           
  Lines        3915     3915           
  Branches      897      897           
=======================================
  Hits         3581     3581           
  Misses        296      296           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e197f15...4a775bb. Read the comment docs.

@yurishkuro
Copy link
Member

Patch check is not required for merge
image

@tiffon
Copy link
Member Author

tiffon commented Jul 17, 2019

@yurishkuro The intent of this PR is to remove it from the overall repo status check, which drives the green checkbox or red x next to the repo name in the header, by limiting the patch check to pull requests.

Screen Shot 2019-07-16 at 5 24 22 PM

@yurishkuro
Copy link
Member

I still don't follow. Patch == PR, is it not? Or do you mean we're getting this as red on master builds?

@tiffon
Copy link
Member Author

tiffon commented Jul 17, 2019

@yurishkuro I believe the patch status check runs on master based on the most recent merge. That's my theory, anyway.

The field only_pulls is from the docs on commit status, which show the default config:

coverage:
  status:
    patch:
      default:
        # basic
        target: auto
        threshold: null
        base: auto 
        # advanced
        branches: null
        if_no_uploads: error
        if_not_found: success
        if_ci_failed: error
        only_pulls: false
        flags: null
        paths: null

It's my assumption that only_pulls will only apply the check to PRs.

@yurishkuro yurishkuro merged commit 861c016 into jaegertracing:master Jul 17, 2019
@tiffon
Copy link
Member Author

tiffon commented Jul 17, 2019

@yurishkuro I'm not so sure it worked. Will verify with the next PR merged. The config might replace the default for project instead of merging with it.

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…master

Remove patch check from master branch
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants