-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use plexus digraph in jaeger #428
Use plexus digraph in jaeger #428
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
- Coverage 91.54% 91.36% -0.19%
==========================================
Files 176 177 +1
Lines 4034 4040 +6
Branches 966 967 +1
==========================================
- Hits 3693 3691 -2
- Misses 297 306 +9
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming these two commits are the entirety of the diff.
Use plexus digraph in jaeger Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Which problem is this PR solving?
TraceGraph
andTraceDiffGraph
are still using theDirectedGraph
component from plexus.Short description of the changes
Changed
TraceGraph
andTraceDiffGraph
to useDigraph
.Also, tweaked the visuals for
TraceGraph
a bit.