Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plexus digraph in jaeger #428

Merged
merged 5 commits into from
Aug 8, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Aug 1, 2019

Which problem is this PR solving?

TraceGraph and TraceDiffGraph are still using the DirectedGraph component from plexus.

Short description of the changes

Changed TraceGraph and TraceDiffGraph to use Digraph.

Also, tweaked the visuals for TraceGraph a bit.

Before After
diff-mid-master diff-mid-pr
diff-small-master diff-small-pr
diff-small-sans-find-master diff-small-sans-find-pr
tg-mid-master tg-mid-pr
tr-mid-find-master tr-mid-find-pr

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from everett980 August 1, 2019 06:02
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #428 into master will decrease coverage by 0.18%.
The diff coverage is 55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   91.54%   91.36%   -0.19%     
==========================================
  Files         176      177       +1     
  Lines        4034     4040       +6     
  Branches      966      967       +1     
==========================================
- Hits         3693     3691       -2     
- Misses        297      306       +9     
+ Partials       44       43       -1
Impacted Files Coverage Δ
...jaeger-ui/src/components/common/EmphasizedNode.tsx 0% <0%> (ø)
...onents/TraceDiff/TraceDiffGraph/TraceDiffGraph.tsx 90.9% <100%> (-0.76%) ⬇️
...src/components/TracePage/TraceGraph/TraceGraph.tsx 95% <100%> (ø) ⬆️
...components/TraceDiff/TraceDiffGraph/renderNode.tsx 85.71% <50%> (ø)
...-ui/src/components/TracePage/TraceGraph/OpNode.tsx 82.6% <60%> (-12.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219aa76...1554c64. Read the comment docs.

Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming these two commits are the entirety of the diff.

@tiffon tiffon merged commit 5c45963 into jaegertracing:master Aug 8, 2019
@tiffon tiffon deleted the use-plexus-digraph-in-jaeger branch August 8, 2019 03:55
@tiffon tiffon restored the use-plexus-digraph-in-jaeger branch August 8, 2019 03:56
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Use plexus digraph in jaeger
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants