Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QualityMetrics lookback param to hours #581

Merged

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • BE uses hours as a uint not lookback as a duration

Short description of the changes

  • Change API request from /qualitymetrics-v2?service=${service}&lookback=${hours}h to /qualitymetrics-v2?service=${service}&hours=${hours}

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #581 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   93.55%   93.53%   -0.02%     
==========================================
  Files         217      217              
  Lines        5289     5289              
  Branches     1360     1360              
==========================================
- Hits         4948     4947       -1     
- Misses        300      301       +1     
  Partials       41       41              
Impacted Files Coverage Δ
packages/jaeger-ui/src/api/jaeger.js 100.00% <100.00%> (ø)
.../jaeger-ui/src/components/QualityMetrics/index.tsx 91.42% <100.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3335512...4df8aa7. Read the comment docs.

@everett980 everett980 merged commit 92a8406 into jaegertracing:master May 26, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants