-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing trace quality menu title #592
Conversation
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 93.54% 93.56% +0.01%
==========================================
Files 217 217
Lines 5296 5296
Branches 1362 1362
==========================================
+ Hits 4954 4955 +1
+ Misses 301 300 -1
Partials 41 41
Continue to review full report at Codecov.
|
@@ -64,7 +64,7 @@ if (getConfigValue('qualityMetrics.menuEnabled')) { | |||
NAV_LINKS.push({ | |||
to: qualityMetrics.getUrl(), | |||
matches: qualityMetrics.matches, | |||
text: 'Quality Metrics', | |||
text: getConfigValue('qualityMetrics.menuLabel') || 'Trace Quality', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the config type definition here
and instead of || 'Trace Quality'
please use the default config object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Allow customizing Quality Metrics menu title Signed-off-by: Yuri Shkuro <ys@uber.com> * Change default title Signed-off-by: Yuri Shkuro <ys@uber.com> * Move defaults Signed-off-by: Yuri Shkuro <ys@uber.com> * prettier Signed-off-by: Yuri Shkuro <ys@uber.com> * comment Signed-off-by: Yuri Shkuro <ys@uber.com> * default Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
And change default title to Trace Quality