Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor UNSAFE_componentWillReceiveProps to use componentDidUpdate #612

Conversation

tklever
Copy link
Contributor

@tklever tklever commented Aug 11, 2020

Which problem is this PR solving?

Short description of the changes

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #612 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   92.79%   92.77%   -0.02%     
==========================================
  Files         227      227              
  Lines        5911     5909       -2     
  Branches     1491     1491              
==========================================
- Hits         5485     5482       -3     
- Misses        385      386       +1     
  Partials       41       41              
Impacted Files Coverage Δ
packages/jaeger-ui/src/components/App/Page.tsx 100.00% <100.00%> (ø)
...aeger-ui/src/components/DeepDependencies/index.tsx 100.00% <100.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <100.00%> (-1.70%) ⬇️
...ePage/TraceTimelineViewer/VirtualizedTraceView.tsx 92.56% <100.00%> (-0.07%) ⬇️
...kages/jaeger-ui/src/components/TracePage/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe67712...943a525. Read the comment docs.

Migrating these componentWillRecieveProps calls to componentDidUpdate in line with recommendations provided at https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops, stating "If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate"

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
@tklever tklever force-pushed the refactor-UNSAFE-componentWillReceiveProps branch from 1b23c7e to 943a525 Compare August 12, 2020 21:12
@rubenvp8510
Copy link
Collaborator

This looks good.

@yurishkuro yurishkuro merged commit 9cc67df into jaegertracing:master Aug 13, 2020
@tklever tklever deleted the refactor-UNSAFE-componentWillReceiveProps branch August 23, 2020 06:33
@tklever tklever mentioned this pull request Aug 27, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
…aegertracing#612)

Migrating these componentWillRecieveProps calls to componentDidUpdate in line with recommendations provided at https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops, stating "If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate"

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
…aegertracing#612)

Migrating these componentWillRecieveProps calls to componentDidUpdate in line with recommendations provided at https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops, stating "If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate"

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…aegertracing#612)

Migrating these componentWillRecieveProps calls to componentDidUpdate in line with recommendations provided at https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops, stating "If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate"

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants