Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build to Node 10 #649

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

yurishkuro
Copy link
Member

Code coverage breaks with Node 8

$ yarn global add codecov
yarn global v1.22.5
[1/4] Resolving packages...
a@^4.0.0ap@0.0.1[2/4] Fetching packages...
error teeny-request@7.0.1: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.
after_success.2
0.10s$ codecov
codecov: command not found

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fd21606). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #649   +/-   ##
=========================================
  Coverage          ?   93.74%           
=========================================
  Files             ?      227           
  Lines             ?     5902           
  Branches          ?     1483           
=========================================
  Hits              ?     5533           
  Misses            ?      328           
  Partials          ?       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd21606...b6f349e. Read the comment docs.

@yurishkuro yurishkuro merged commit 6827f70 into jaegertracing:master Oct 7, 2020
@yurishkuro yurishkuro deleted the use-node-10 branch October 7, 2020 00:36
jamesfer pushed a commit to jamesfer/jaeger-ui that referenced this pull request Oct 7, 2020
Signed-off-by: Yuri Shkuro <github@ysh.us>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant