Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Tab - Error rate value should be 0-100 value and not 0-1 #895

Merged
merged 8 commits into from
Feb 28, 2022

Conversation

nofar9792
Copy link
Contributor

@nofar9792 nofar9792 commented Feb 24, 2022

Which problem is this PR solving?

Resolves #894

Short description of the changes

before:
Screen Shot 2022-01-25 at 16 14 13

after:
Screen Shot 2022-01-25 at 16 14 06

before:
image

after:
image

נקכםר

Fix
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #895 (f36cb61) into main (77cdfbd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f36cb61 differs from pull request most recent head 8bcb773. Consider uploading reports for the commit 8bcb773 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   95.29%   95.30%           
=======================================
  Files         240      240           
  Lines        7466     7471    +5     
  Branches     1866     1867    +1     
=======================================
+ Hits         7115     7120    +5     
  Misses        345      345           
  Partials        6        6           
Impacted Files Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 98.82% <100.00%> (+0.07%) ⬆️
...nitor/ServicesView/operationDetailsTable/index.tsx 100.00% <100.00%> (ø)
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 94.44% <0.00%> (-5.56%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 94.48% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cdfbd...8bcb773. Read the comment docs.

@nofar9792 nofar9792 marked this pull request as draft February 24, 2022 15:49
yurishkuro
yurishkuro previously approved these changes Feb 24, 2022
@nofar9792 nofar9792 marked this pull request as ready for review February 28, 2022 12:25
@nofar9792
Copy link
Contributor Author

@yurishkuro @albertteoh can you merge it please?

@nofar9792
Copy link
Contributor Author

I fixed the 2nd place: the service error rate graph

@yurishkuro yurishkuro merged commit 6e06ce0 into jaegertracing:main Feb 28, 2022
@nofar9792 nofar9792 deleted the error-rate-operation-table branch February 28, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Tab - Error rate value should be 0-100 value and not 0-1
2 participants