Bump @pyroscope/flamegraph to 0.18.4 #977
Conversation
Signed-off-by: pavelpashkovsky <pavelpashkovsky@gmail.com>
pavelpashkovsky
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 95.29% 95.42% +0.13%
==========================================
Files 243 243
Lines 7560 7560
Branches 1892 1892
==========================================
+ Hits 7204 7214 +10
+ Misses 349 339 -10
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@jaegertracing/plexus": "0.2.0", | |||
| "@pyroscope/flamegraph": "0.18.4-1379-557f0b4.0", | |||
| "@pyroscope/flamegraph": "0.18.4", | |||
There was a problem hiding this comment.
while I have you, I wanted to ask - in the last merge I am seeing that the numbers in the flame graph & table are in "units", which is pretty confusing. It sounds like a technical reason (library may not know the units of numbers), but couldn't we pass some parameter to it to make it more obvious? Also, I'm just curious under what conditions the numbers in the flamegraph are not time units - if they are always time than it seems like the graph could always display them with proper time units like s, ms, etc.
There was a problem hiding this comment.
The flamegraph component can be used for visualizing other arbitrary data that does have other units.
Makes sense though that for traces it will always be time so made a Pr to fix this:
grafana/pyroscope#1387
It's released now in flamegraph v0.18.5
Signed-off-by: pavelpashkovsky pavelpashkovsky@gmail.com
Which problem is this PR solving?
@pyroscope/flamegraphto0.18.4Short description of the changes
☑︎ Added indication of which column is sorted visually
☑︎ When "self" is 0 then table will show 0.00