Call setExpvarOptions method inside Initialize

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
jaegertracing · Sep 22, 2020 · 0bd8431 · 0bd8431
1 parent 2123f10
commit 0bd8431
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/plugin/storage/factory.go b/plugin/storage/factory.go
@@ -82,7 +82,6 @@ func NewFactory(config FactoryConfig) (*Factory, error) {
 		}
 		f.factories[t] = ff
 	}
-	f.setExpvarOptions()
 	return f, nil
 }
 
@@ -113,6 +112,7 @@ func (f *Factory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger)
 			return err
 		}
 	}
+	f.setExpvarOptions()
 	return nil
 }
 

diff --git a/plugin/storage/factory_test.go b/plugin/storage/factory_test.go
@@ -358,6 +358,10 @@ func TestSetExpvarOptions(t *testing.T) {
 	f, err := NewFactory(defaultCfg())
 	require.NoError(t, err)
 
+	m := metrics.NullFactory
+	l := zap.NewNop()
+	f.Initialize(m, l)
+
 	gotDownsamplingRatio := expvar.Get(downsamplingRatio)
 
 	assert.Equal(t, f.DownsamplingRatio, gotDownsamplingRatio)