Fix ES OTEL status code (#2501)

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
jaegertracing · Sep 22, 2020 · 2e1b869 · 2e1b869
1 parent 9039481
commit 2e1b869
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go b/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go
@@ -367,8 +367,7 @@ func getTagFromSpanKind(spanKind pdata.SpanKind) (dbmodel.KeyValue, bool) {
 
 func getTagFromStatusCode(statusCode pdata.StatusCode) (dbmodel.KeyValue, bool) {
 	return dbmodel.KeyValue{
-		Key: tracetranslator.TagStatusCode,
-		// TODO is this ok?
+		Key:   tracetranslator.TagStatusCode,
 		Value: statusCode.String(),
 		Type:  dbmodel.StringType,
 	}, true

diff --git a/...pentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go b/...pentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go
@@ -151,7 +151,7 @@ func TestConvertSpan(t *testing.T) {
 				StartTimeMillis: 1,
 				Tags: []dbmodel.KeyValue{
 					{Key: "span.kind", Type: dbmodel.StringType, Value: "client"},
-					{Key: "status.code", Type: dbmodel.StringType, Value: "Cancelled"},
+					{Key: "status.code", Type: dbmodel.StringType, Value: "STATUS_CODE_CANCELLED"},
 					{Key: "error", Type: dbmodel.BoolType, Value: "true"},
 					{Key: "status.message", Type: dbmodel.StringType, Value: "messagetext"},
 					{Key: "foo", Type: dbmodel.BoolType, Value: "true"},