Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: albertteoh <albert.teoh@logz.io>
  • Loading branch information
albertteoh committed May 3, 2021
1 parent dcc6ca3 commit 8a14cb7
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion model/proto/metrics/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ message MetricsQueryBaseRequest {
message GetLatenciesRequest {
MetricsQueryBaseRequest baseRequest = 1;
// quantile is the quantile to compute from latency histogram metrics.
// Valid range: 0 - 1 (inclusive).
//
// e.g. 0.99 will return the 99th percentile or P99 which is the worst latency
// observed from 99% of all spans for the given service (and operation).
//
// Required.
double quantile = 2;
}
Expand Down Expand Up @@ -114,7 +119,8 @@ message GetMetricsResponse {
}

service MetricsQueryService {
// GetMinStepDuration gets the min step duration supported by the backing metrics store.
// GetMinStepDuration gets the min time resolution supported by the backing metrics store,
// e.g. 10s means the backend can only return data points that are at least 10s apart, not closer.
rpc GetMinStepDuration(GetMinStepDurationRequest) returns (GetMinStepDurationResponse);

// GetLatencies gets the latency metrics for a given list of services grouped by service
Expand Down

0 comments on commit 8a14cb7

Please sign in to comment.