Renamed fixture files, updated expected sampling probabilities to avo…

…id being treated as empty during marshaling/unmarshaling Signed-off-by: Kazimieras Pociunas <kazimieras.pociunas@gmail.com>
jaegertracing · Mar 19, 2024 · cd75115 · cd75115
1 parent 19a9c60
commit cd75115
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/...stic_with_default_operation_strategy.json → ...tionStrategies_response_for_ServiceA.json b/...stic_with_default_operation_strategy.json → ...tionStrategies_response_for_ServiceA.json
@@ -7,7 +7,9 @@
         "perOperationStrategies": [
             {
                 "operation": "/health",
-                "probabilisticSampling": {}
+                "probabilisticSampling": {
+                    "samplingRate": 0.1
+                }
             }
         ]
     }

diff --git a/...ting_with_default_operation_strategy.json → ...tionStrategies_response_for_ServiceB.json b/...ting_with_default_operation_strategy.json → ...tionStrategies_response_for_ServiceB.json
@@ -8,7 +8,9 @@
         "perOperationStrategies": [
             {
                 "operation": "/health",
-                "probabilisticSampling": {}
+                "probabilisticSampling": {
+                    "samplingRate": 0.1
+                }
             }
         ]
     }

diff --git a/plugin/sampling/strategystore/static/fixtures/service_no_per_operation.json b/plugin/sampling/strategystore/static/fixtures/service_no_per_operation.json
@@ -18,7 +18,7 @@
            {
              "operation": "/health",
              "type": "probabilistic",
-             "param": 0.0
+             "param": 0.1
            }
          ]
        }

diff --git a/plugin/sampling/strategystore/static/strategy_store_test.go b/plugin/sampling/strategystore/static/strategy_store_test.go
@@ -473,7 +473,7 @@ func TestServiceNoPerOperationStrategies(t *testing.T) {
 
 	// expected response for ServiceA (which has probablistic service level sampling strategy)
 	// shall contain /health operation with default service level sampling strategy as well
-	expectedServiceAResponse, errServiceA := makeServiceStrategyResponseFromFile("fixtures/probablistic_with_default_operation_strategy.json")
+	expectedServiceAResponse, errServiceA := makeServiceStrategyResponseFromFile("fixtures/TestServiceNoPerOperationStrategies_response_for_ServiceA.json")
 	require.NoError(t, errServiceA)
 
 	strategy, err := store.GetSamplingStrategy(context.Background(), "ServiceA")
@@ -483,8 +483,8 @@ func TestServiceNoPerOperationStrategies(t *testing.T) {
 	assert.Equal(t, expectedServiceAResponse, strategy)
 
 	// expected response for ServiceB (which has ratelimiting service level sampling strategy)
-	// shall contain /health operation with sampling probability taken from defaul operation level strategy
-	expectedServiceBResponse, errServiceB := makeServiceStrategyResponseFromFile("fixtures/ratelimiting_with_default_operation_strategy.json")
+	// shall contain /health operation with sampling probability taken from default operation level strategy
+	expectedServiceBResponse, errServiceB := makeServiceStrategyResponseFromFile("fixtures/TestServiceNoPerOperationStrategies_response_for_ServiceB.json")
 	require.NoError(t, errServiceB)
 
 	strategy, err = store.GetSamplingStrategy(context.Background(), "ServiceB")