Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deprecate] Remove support for OTEL spanmetrics processor #4736

Closed
3 tasks done
yurishkuro opened this issue Sep 9, 2023 · 3 comments · Fixed by jaegertracing/documentation#709
Closed
3 tasks done

[deprecate] Remove support for OTEL spanmetrics processor #4736

yurishkuro opened this issue Sep 9, 2023 · 3 comments · Fixed by jaegertracing/documentation#709

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Sep 9, 2023 •
edited
Loading

Support for spanmetrics connector was added in v1.46.0 (#4452, June) and made to be the default in v1.49.0 (#4704, Sep).

cc @albertteoh
@yurishkuro yurishkuro mentioned this issue Sep 10, 2023
Merged
yurishkuro added a commit that referenced this issue Sep 10, 2023
@yurishkuro
[SPM] Deprecate support for Spanmetrics Processor naming convention (#…
a15f3a3 
…4741)

## Which problem is this PR solving?
- Part 1 of #4736

## Description of the changes
- Add deprecation notice to CLI flag
- Add log message when using span metrics processor notation

## How was this change tested?
```
$ go run ./cmd/all-in-one help
      --prometheus.query.support-spanmetrics-connector            (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)  Controls whether the metrics queries should match the OpenTelemetry Collector's spanmetrics connector naming (when true) or spanmetrics processor naming (when false). (default true)

$ PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR=false METRICS_STORAGE_TYPE=prometheus go run ./cmd/all-in-one
2023/09/09 20:29:19 using Spanmetrics Processor's metrics naming conventions (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)
```

cc @albertteoh

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels May 10, 2024
@varshith257 varshith257 mentioned this issue May 23, 2024
Closed
4 tasks
@varshith257
Copy link
Contributor

varshith257 commented May 23, 2024 •
edited
Loading

@yurishkuro Regarding Deprecation of SpanProcessor Metrics. I have came across a case in metrics.go that some parts of it's code is using SPM. Does it need to replace that SPM fields with Span connector fields?

@varshith257 varshith257 mentioned this issue Jun 5, 2024
Merged
4 tasks
@varshith257
Copy link
Contributor

@yurishkuro Can I ahead to make updates in docs repo?

@yurishkuro
Copy link
Member Author

Yes

@yurishkuro yurishkuro mentioned this issue Jun 14, 2024
Merged
@yurishkuro yurishkuro removed help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to SpanMetrics Processor yurishkuro/jaeger-docs
2 participants
@yurishkuro @varshith257