Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The CHILD_OF span reference is moved to the second place incorrectly #5122

Closed
sherwoodwang opened this issue Jan 19, 2024 · 1 comment · Fixed by #5121
Closed

[Bug]: The CHILD_OF span reference is moved to the second place incorrectly #5122

sherwoodwang opened this issue Jan 19, 2024 · 1 comment · Fixed by #5121
Labels

Comments

@sherwoodwang
Copy link
Contributor

What happened?

When the first span reference is typed as 'CHILD_OF' and other references are 'FOLLOWS_FROM' with the same trace id, the first 'CHILD_OF' span referenced is swapped to the second place.

Steps to reproduce

Create a span with 2 references. The first is a 'CHILD_OF' reference. The second is a 'FOLLOWS_FROM' reference. Both of them point to spans of the same trace id with the referencing one.

Expected behavior

The order should be unchanged.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@yurishkuro
Copy link
Member

Could you explain what made you investigate, what user-facing problem this was causing?

yurishkuro pushed a commit that referenced this issue Jan 19, 2024
## Which problem is this PR solving?
- Resolves #5122

## Description of the changes
- Avoid changing order in the case described above.

## How was this change tested?
- A test case is added.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [X] I have added unit tests for the new functionality
- [X] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Sherwood Wang <sherwoodwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants