Add pprof and create admin endpoint

[konradgaluszka]

Resolves #1315

Refactored healthcheck package to have admin endpoint with both healthcheck and pprof endpoints

[yurishkuro]

looks good overall. Please get the build green (make fmt, etc.)

[yurishkuro]

Hm, I thought we had some bot that would add lint failures as comments on the appropriate lines.

The build is failing with:

Lint Failures
/home/travis/gopath/src/github.com/jaegertracing/jaeger/pkg/adminendpoint/adminendpoint.go:31:1: comment on exported type AdminEndpoint should be of the form "AdminEndpoint ..." (with optional leading article)
/home/travis/gopath/src/github.com/jaegertracing/jaeger/pkg/adminendpoint/healthcheck/healthcheck.go:100:1: comment on exported method HealthCheck.GetHandlerFunc should be of the form "GetHandlerFunc ..."

[konradgaluszka]

There are still some build errors, I will check it..

[codecov]

Codecov Report

Merging #1375 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         173      173           
  Lines        8179     8179           
=======================================
  Hits         8165     8165           
  Misses          7        7           
  Partials        7        7

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb6ea7...47a3b83. Read the comment docs.

[yurishkuro]

restarted crossdock integration test 3 times, it keeps failing, might be something to do with this PR.

[yurishkuro]

e.g. the renaming of the health port CLI flag

[konradgaluszka]

The build is not stable for some reason. I've triggered it 3 times and got 3 different results. Crossdock was failing on my local machine 50% of the time even without my changes.

[pavolloffay]

@konradgaluszka did you manage to get stable builds? I have restarted travis and it seems to be fine.

@yurishkuro could this be merged?

[konradgaluszka]

@konradgaluszka did you manage to get stable builds? I have restarted travis and it seems to be fine.

I am afraid build is still unstable. I was running the build locally on master branch (before my change) and still got failures in crossdock:

✗ [endtoend] test_driver→ (services=go) ⇒ Fail: could not retrieve traces from query service
✓ [endtoend] test_driver→ (services=java) ⇒ Pass
✓ [endtoend] test_driver→ (services=node) ⇒ Pass
✓ [endtoend] test_driver→ (services=python) ⇒ Pass
✓ [endtoend] test_driver→ (services=zipkin-brave-json) ⇒ Pass
✓ [endtoend] test_driver→ (services=zipkin-brave-json-v2) ⇒ Pass
✓ [endtoend] test_driver→ (services=zipkin-brave-thrift) ⇒ Pass

Do you have consistent runs for ./scripts/travis/build-crossdock.sh?

[objectiser]

This test seems to be unstable, not related to this PR:

--- FAIL: TestSaramaConsumerWrapper_start_Messages (0.01s)
    consumer_test.go:161: PASS:	Process(*consumer.saramaMessageWrapper)
    metricstest.go:49: 
        	Error Trace:	metricstest.go:49
        	            				metricstest.go:37
        	            				consumer_test.go:167
        	Error:      	Not equal: 
        	            	expected: int(0)
        	            	actual  : int64(1)
        	Test:       	TestSaramaConsumerWrapper_start_Messages
        	Messages:   	expected metric name: sarama-consumer.partitions-held, tags: map[]

[jpkrohling]

LGTM, just need to either document the breaking change or provide a backwards compatible option.

[konradgaluszka]

LGTM, just need to either document the breaking change or provide a backwards compatible option.

I couldn't use aliasing in viper, because it does not work with reading from config:
spf13/viper#560

[jpkrohling]

@konradgaluszka, looks like this last commit failed the DCO. Would you please amend it?

[yurishkuro]

Thanks!