Remove deprecated kafka flags

[ledor473]

They are deprecated in favor of kafka.producer and kafka.consumer flags

Which problem is this PR solving?

• Closes [ingester] Crash if Kafka is specified as storage #1190
• Follow up of Kafka: Add new Consumer and Producer flags #1360

Short description of the changes

• Address this comment to remove whitespace: Kafka: Add new Consumer and Producer flags #1360 (comment)
• The flags were still defined twice, so the crash described in [ingester] Crash if Kafka is specified as storage #1190 still exists. Now it does not:

$ SPAN_STORAGE_TYPE=kafka go run cmd/ingester/main.go -h

Jaeger ingester consumes spans from a particular Kafka topic and writes them to all configured storage types.

Usage:
  (experimental) jaeger-ingester [flags]
  (experimental) [command]

Available Commands:
  env         Help about environment variables
  help        Help about any command
  version     Print the version

Flags:
      --config-file string                   Configuration file in JSON, TOML, YAML, HCL, or Java properties formats (default none). See spf13/viper for precedence.
      --downsampling.hashsalt string         Salt used when hashing trace id for downsampling.
      --downsampling.ratio float             Ratio of spans passed to storage after downsampling (between 0 and 1), e.g ratio = 0.3 means we are keeping 30% of spans and dropping 70% of spans; ratio = 1.0 disables downsampling. (default 1)
      --health-check-http-port int           The http port for the health check service (default 14270)
  -h, --help                                 help for (experimental)
      --ingester.deadlockInterval duration   Interval to check for deadlocks. If no messages gets processed in given time, ingester app will exit. Value of 0 disables deadlock check. (default 1m0s)
      --ingester.http-port int               The http port for the ingester service (default 14271)
      --ingester.parallelism string          The number of messages to process in parallel (default "1000")
      --kafka.consumer.brokers string        The comma-separated list of kafka brokers. i.e. '127.0.0.1:9092,0.0.0:1234' (default "127.0.0.1:9092")
      --kafka.consumer.encoding string       The encoding of spans ("json", "protobuf", "zipkin-thrift") consumed from kafka (default "protobuf")
      --kafka.consumer.group-id string       The Consumer Group that ingester will be consuming on behalf of (default "jaeger-ingester")
      --kafka.consumer.topic string          The name of the kafka topic to consume from (default "jaeger-spans")
      --kafka.producer.brokers string        (experimental) The comma-separated list of kafka brokers. i.e. '127.0.0.1:9092,0.0.0:1234' (default "127.0.0.1:9092")
      --kafka.producer.encoding string       (experimental) Encoding of spans ("json" or "protobuf") sent to kafka. (default "protobuf")
      --kafka.producer.topic string          (experimental) The name of the kafka topic (default "jaeger-spans")
      --log-level string                     Minimal allowed log Level. For more levels see https://github.com/uber-go/zap (default "info")
      --metrics-backend string               Defines which metrics backend to use for metrics reporting: expvar, prometheus, none (default "prometheus")
      --metrics-http-route string            Defines the route of HTTP endpoint for metrics backends that support scraping (default "/metrics")
      --span-storage.type string             Deprecated; please use SPAN_STORAGE_TYPE environment variable. Run this binary with "env" command for help.

Use "(experimental) [command] --help" for more information about a command.

[ledor473]

Before we merge, I'd like to try the Kafka to Kafka flow.

[codecov]

Codecov Report

Merging #1424 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1424   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         165     165           
  Lines        7572    7503   -69     
======================================
- Hits         7572    7503   -69

Impacted Files	Coverage Δ
plugin/storage/kafka/options.go	100% <ø> (ø)	⬆️
cmd/ingester/app/flags.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44eaf08...99a965c. Read the comment docs.