Avoid process crash when elasticsearch response is nil #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YEXINGZHE54
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Add nil pointer check in elasticsearch bulkprocessor's after callback, defined inside pkg/es/config/config.go. In some rare cases, elasticsearch request will return error with nil response, and then nil response will be passed into after callback, and using of nil pointer will cause process crash. Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com>
YEXINGZHE54
force-pushed
the
fix-es-nil-response-check
branch
from
da31b83
to
3d131c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 173 173
Lines 8179 8179
=======================================
Hits 8165 8165
Misses 7 7
Partials 7 7Continue to review full report at Codecov.
|
pavolloffay
reviewed
Apr 10, 2019
pkg/es/config/config.go
Outdated
| var respval interface{} | ||
| if response == nil { | ||
| failed = 0 | ||
| respval = "nil" |
There was a problem hiding this comment.
isn't this logged by default as nil when it's nil?
There was a problem hiding this comment.
yes , it will be logged as null by default; I will remove unneeded action
Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com>
pavolloffay
approved these changes
Apr 10, 2019
stefanvassilev
pushed a commit
to stefanvassilev/jaeger
that referenced
this pull request
Apr 10, 2019
* Avoid process crash when elasticsearch response is nil Add nil pointer check in elasticsearch bulkprocessor's after callback, defined inside pkg/es/config/config.go. In some rare cases, elasticsearch request will return error with nil response, and then nil response will be passed into after callback, and using of nil pointer will cause process crash. Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com> * Remove unnecessary wrap arround nil pointer in log Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com>
stefanvassilev
pushed a commit
to stefanvassilev/jaeger
that referenced
this pull request
Apr 10, 2019
* Avoid process crash when elasticsearch response is nil Add nil pointer check in elasticsearch bulkprocessor's after callback, defined inside pkg/es/config/config.go. In some rare cases, elasticsearch request will return error with nil response, and then nil response will be passed into after callback, and using of nil pointer will cause process crash. Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com> * Remove unnecessary wrap arround nil pointer in log Signed-off-by: Li Zhaoxing <lizhaoxing@4paradigm.com> Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nil pointer check in elasticsearch bulkprocessor's
after callback, defined inside pkg/es/config/config.go.
In some rare cases, elasticsearch request will return
error with nil response, and then nil response will
be passed into after callback, and using of nil pointer
will cause process crash.
Signed-off-by: YEXINGZHE54 429567185@qq.com
Which problem is this PR solving?
Short description of the changes