supports customized kafka client id #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newly12
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Signed-off-by: Peter Deng <yundeng@ebay.com>
Signed-off-by: Peter Deng <yundeng@ebay.com>
newly12
force-pushed
the
jaeger_ingester_supports_kafka_client_id
branch
from
6357bae
to
0143c36
Compare
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
=========================================
Coverage ? 99.79%
=========================================
Files ? 182
Lines ? 8716
Branches ? 0
=========================================
Hits ? 8698
Misses ? 9
Partials ? 9
Continue to review full report at Codecov.
|
vprithvi
reviewed
Apr 29, 2019
| @@ -46,6 +46,7 @@ func (s *KafkaIntegrationTestSuite) initialize() error { | |||
| s.logger, _ = testutils.NewLogger() | |||
| const encoding = "json" | |||
| const groupID = "kafka-integration-test" | |||
| const ClientID = "kafka-integration-test" | |||
There was a problem hiding this comment.
Thanks. it's updated.
vprithvi
approved these changes
Apr 29, 2019
Signed-off-by: Peter Deng <newly.deng@gmail.com>
vprithvi
reviewed
Apr 30, 2019
cmd/ingester/app/flags.go
Outdated
| @@ -64,6 +68,7 @@ const ( | |||
| // Options stores the configuration options for the Ingester | |||
| type Options struct { | |||
| kafkaConsumer.Configuration | |||
| ClientID string | |||
There was a problem hiding this comment.
I didn't notice this earlier - but we should move this to kafkaConsumer.Configuration which is where GroupID/Topic/etc are configured.
There was a problem hiding this comment.
yes it is redundant. it is removed.
Signed-off-by: Peter Deng <yundeng@ebay.com>
newly12
force-pushed
the
jaeger_ingester_supports_kafka_client_id
branch
from
d2d379d
to
6d7328c
Compare
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1506
Short description of the changes
supports customized kafka client id in ingester