Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for bearer-token-propagation #1642

Conversation

wsoula
Copy link

@wsoula wsoula commented Jun 28, 2019

To false for backwards compatibility
Fixes #1641

Which problem is this PR solving?

Short description of the changes

To false for backwards compatibility
Fixes jaegertracing#1641

Signed-off-by: Will Soula <william.soula@drillinginfo.com>
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1642 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1642   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         193      193           
  Lines        9214     9214           
=======================================
  Hits         9097     9097           
  Misses         90       90           
  Partials       27       27
Impacted Files Coverage Δ
cmd/query/app/flags.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3181b98...fa1422c. Read the comment docs.

@pavolloffay
Copy link
Member

cc) @objectiser @jpkrohling

@pavolloffay pavolloffay merged commit cce78b8 into jaegertracing:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from 1.12.0 to 1.13.0 causes Error 403 (Forbidden)
2 participants