[badger] Filter duplicate results from a single indexSeek [fixes #1604] #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
+ Coverage 98.7% 98.71% +<.01%
==========================================
Files 193 193
Lines 9224 9228 +4
==========================================
+ Hits 9105 9109 +4
Misses 91 91
Partials 28 28
Continue to review full report at Codecov.
|
…#1604 Signed-off-by: Michael Burman <yak@iki.fi>
yurishkuro
changed the title
yurishkuro
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Burman yak@iki.fi
Which problem is this PR solving?
Resolves #1604, seeing multiple traces in the UI
Short description of the changes
Changes to the badger storage backend reader part (no changes to write path):
Filtering duplicates from the index key results when those occur in the same index seek. Previously only cross-index-seeks had their duplicates removed. Also added a test to ensure this does not break anymore.