Upgrade and fix dependencies #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yurishkuro
commented
Nov 7, 2019
•
yurishkuro
commented
- Resolves Master does not build on Windows #1906
- Upgrades x/sys to a version compatible with prometheus client.
- Include build of all platform binaries in the PR runs, not just deploy step
- Fixes the issue with cobra/blackfriday/go-md2man whose latest versions don't work on dep, only on go modules.
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
added 2 commits
November 7, 2019 16:31
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
guo0693
approved these changes
Nov 7, 2019
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 98.46% 98.44% -0.03%
==========================================
Files 197 197
Lines 9648 9648
==========================================
- Hits 9500 9498 -2
- Misses 113 114 +1
- Partials 35 36 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.