Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tracer config via env vars #1919

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • invoke FromEnv on the tracer configuration object before creating a tracer so that default configuration can be overwritten via environment variables.

Tested with all-in-one by running it on different port, re-pointing the tracer to the new port, and validating messages via tcpdump:

JAEGER_AGENT_PORT=7701 go run -tags=ui ./cmd/all-in-one \
    --processor.jaeger-binary.server-host-port :7700 \
    --processor.jaeger-compact.server-host-port :7701 \
    --processor.zipkin-compact.server-host-port :7702 \
    --http-server.host-port :7703

sudo tcpdump -i any -Z root "udp port 7701" -w out.cap

Signed-off-by: Yuri Shkuro <ys@uber.com>
Yuri Shkuro added 2 commits November 12, 2019 13:47
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1919 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
- Coverage   98.48%   98.45%   -0.03%     
==========================================
  Files         198      198              
  Lines        9740     9740              
==========================================
- Hits         9592     9590       -2     
- Misses        113      114       +1     
- Partials       35       36       +1
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 86.84% <0%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6086ec...9601a45. Read the comment docs.

@yurishkuro yurishkuro merged commit db0bf99 into jaegertracing:master Nov 12, 2019
@yurishkuro yurishkuro deleted the tracer-via-env branch November 12, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Query expects agent at localhost
2 participants