Update python pathlib to pathlib2 #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Signed-off-by: Gary Brown <gary@brownuk.com>
objectiser
requested review from
black-adder,
jpkrohling,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
jpkrohling
approved these changes
Nov 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.02%
==========================================
Files 198 198
Lines 9744 9744
==========================================
+ Hits 9592 9594 +2
+ Misses 116 114 -2
Partials 36 36
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Nov 18, 2019
pavolloffay
changed the title
jpkrohling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to pathlib2, which is an actively maintained version.
Signed-off-by: Gary Brown gary@brownuk.com
Which problem is this PR solving?
Pathlib is a very old python lib, which has a more actively maintained backward compatible version called pathlib2.
Short description of the changes
Install pathlib2 within the rollover Dockerfile, and update the import in the rollover script.
Has been tested locally by running the rollover init command.