Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc & http endpoint to query operations by service & spanKind #1943

Merged
merged 6 commits into from
Nov 26, 2019

Conversation

guo0693
Copy link
Contributor

@guo0693 guo0693 commented Nov 25, 2019

Signed-off-by: Jun Guo guo0693@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Update grpc & http endpoint to query operations by service & spanKind
  • legacy http endpoint will stay unchanged: /services/%s/operations

- legacy http endpoint will stay unchanged: /services/%s/operations

Signed-off-by: Jun Guo <guo0693@gmail.com>
cmd/query/app/grpc_handler.go Outdated Show resolved Hide resolved
cmd/query/app/grpc_handler_test.go Show resolved Hide resolved
Signed-off-by: Jun Guo <guo0693@gmail.com>
Signed-off-by: Jun Guo <guo0693@gmail.com>
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1943 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   98.43%   98.46%   +0.02%     
==========================================
  Files         198      199       +1     
  Lines        9851     9875      +24     
==========================================
+ Hits         9697     9723      +26     
+ Misses        117      116       -1     
+ Partials       37       36       -1
Impacted Files Coverage Δ
cmd/query/app/query_parser.go 100% <ø> (ø) ⬆️
cmd/query/app/util.go 100% <100%> (ø)
cmd/query/app/querysvc/query_service.go 100% <100%> (+2.98%) ⬆️
cmd/query/app/http_handler.go 100% <100%> (ø) ⬆️
cmd/query/app/grpc_handler.go 97.61% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57e4b7...efb7d62. Read the comment docs.

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved
cmd/query/app/http_handler.go Outdated Show resolved Hide resolved
cmd/query/app/http_handler.go Outdated Show resolved Hide resolved
cmd/query/app/http_handler.go Outdated Show resolved Hide resolved
cmd/query/app/http_handler_test.go Outdated Show resolved Hide resolved
model/proto/api_v2/query.proto Show resolved Hide resolved
cmd/query/app/http_handler.go Show resolved Hide resolved
@yurishkuro yurishkuro merged commit 9cd7a7e into jaegertracing:master Nov 26, 2019
@pavolloffay pavolloffay added this to the Release 1.16 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants