Export SaveSpan to enable multiplexing #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertteoh
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
* Allows additional HTTP endpoints to call the same SaveSpan function Signed-off-by: Albert Teoh <albteo@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 203 203
Lines 10061 10061
=======================================
Hits 9759 9759
Misses 264 264
Partials 38 38
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Dec 9, 2019
yurishkuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #1967 where it is not possible to add new endpoints that call the same "SaveSpan" function. This is required for differentiating authenticated "external" endpoints from "internal" endpoints that do not require (and cannot provide) authentication.
Short description of the changes
Export the
saveSpanfunction incmd/collector/app/http_handler.gotoSaveSpanwhich allows for embedding theAPIHandlerinto a struct for extending.