Allow raw port numbers for UDP servers #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
vprithvi
reviewed
Jan 16, 2020
cmd/agent/app/flags.go
Outdated
| return b | ||
| } | ||
|
|
||
| func toHostPort(v string) string { |
There was a problem hiding this comment.
What happens if someone is running on a IPV6 host with the address of the form 2001:0db8:85a3:0000:0000:8a2e:0370:7334 ?
There was a problem hiding this comment.
so really I was trying to catch a raw number here, so I could instead try Long.parse()
Signed-off-by: Yuri Shkuro <ys@uber.com>
vprithvi
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
- Coverage 97.41% 97.39% -0.02%
==========================================
Files 207 207
Lines 10243 10247 +4
==========================================
+ Hits 9978 9980 +2
Misses 223 223
- Partials 42 44 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently flags like
--processor.jaeger-binary.server-host-port 5001result in a failure. I think we can be more flexible since in most cases the host is not required, just the port.