Clock skew config #2119
Merged
Clock skew config #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Mar 10, 2020
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
force-pushed
the
clock-skew-config
branch
from
c713a39
to
250877d
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2119 +/- ##
==========================================
+ Coverage 96.1% 96.13% +0.02%
==========================================
Files 217 218 +1
Lines 10538 10564 +26
==========================================
+ Hits 10128 10156 +28
+ Misses 354 353 -1
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Mar 10, 2020
Signed-off-by: Joe Elliott <number101010@gmail.com>
yurishkuro
approved these changes
Mar 10, 2020
|
Can we get code coverage up? |
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
Test pushed that should raise coverage. It's a bit trivial as it just asserts nil and non-nil fields on the QueryServiceOptions struct after building. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
query.max-clock-skew-adjustNote that I consolidated the creation of
QueryServiceOptionsin thecmd/query/apppackage. I don't necessarily think this is a great place for it, but I struggled to find a better one. If you have recommendations please let me know.